Skip to content

Add models for wyckoff_positions - #2427

Merged
ml-evs merged 2 commits into
mainfrom
ml-evs/wyckoff
Aug 6, 2026
Merged

Add models for wyckoff_positions#2427
ml-evs merged 2 commits into
mainfrom
ml-evs/wyckoff

Conversation

@ml-evs

@ml-evs ml-evs commented Jul 28, 2026

Copy link
Copy Markdown
Member

This pull request adds support for the optional wyckoff_positions property to the structures resource.

@codecov

codecov Bot commented Jul 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.35%. Comparing base (e88ddb6) to head (4286f77).

Files with missing lines Patch % Lines
optimade/models/structures.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2427      +/-   ##
==========================================
- Coverage   90.39%   90.35%   -0.04%     
==========================================
  Files          78       78              
  Lines        5110     5120      +10     
==========================================
+ Hits         4619     4626       +7     
- Misses        491      494       +3     
Flag Coverage Δ
project 90.35% <90.90%> (-0.04%) ⬇️
validator 90.35% <90.90%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ml-evs
ml-evs marked this pull request as ready for review August 6, 2026 08:16
@ml-evs
ml-evs requested a review from CasperWA as a code owner August 6, 2026 08:16
@ml-evs
ml-evs merged commit 5ad3b5d into main Aug 6, 2026
13 checks passed
@ml-evs
ml-evs deleted the ml-evs/wyckoff branch August 6, 2026 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant